Ticket #45508

fc_strrep_resize() not working on NDEBUG build

Open Date: 2022-08-29 19:11 Last Update: 2022-09-01 07:58

Reporter:
Owner:
Type:
Status:
Closed
Component:
MileStone:
Priority:
5 - Medium
Severity:
5 - Medium
Resolution:
Fixed
File:
1

Details

fc_strrep_resize() has:

#ifndef FREECIV_NDEBUG
bool success = fc_strrep(str, (*len), search, replace);
#endif

The purpose has (clearly?) been to not have 'success' variable in NDEBUG build, but the fc_strrep() call should still be made for its side effects.

Ticket History (3/6 Histories)

2022-08-29 19:11 Updated by: cazfi
  • New Ticket "fc_strrep_resize() not working on NDEBUF build" created
2022-08-29 19:26 Updated by: cazfi
  • Summary Updated
2022-08-29 22:45 Updated by: cazfi
Comment

fc_strrep_resize() is used only by freeciv-manual. The kind of people who use freeciv-manual are unlikely to be using NDEBUG builds, so I think actual impact of this bug to be really minor.

2022-08-29 23:59 Updated by: cazfi
  • Owner Update from (None) to cazfi
  • Resolution Update from None to Accepted
2022-09-01 07:58 Updated by: cazfi
  • Status Update from Open to Closed
  • Resolution Update from Accepted to Fixed

Attachment File List

Edit

Please login to add comment to this ticket » Login