savegame3.c: dead 'i' assignment in multipliers order saving

• Reporter: cazfi
• Owner: cazfi
• Type: Bugs
• Status: Closed
• Component: Server
• MileStone: 3.0.4 (closed)
• Priority: 5 - Medium
• Severity: 5 - Medium
• Resolution: Fixed
• File: 2

Details

As reported by clang analyzer (from S3_0) savegame3.c:1777 "i = 0;" is a dead assignment. That block does not use 'i' as a counter, but 'multiplier_index(pmul)'

Ticket History (3/6 Histories)

2022-09-21 17:55 Updated by: cazfi

• New Ticket "savagame3.c: dead 'i' assignment in multipliers order saving" created

2022-09-22 01:58 Updated by: cazfi

• File 0040-Fix-dead-assignment-of-i-in-saving-multipliers-order.patch (File ID: 10353) is attached

2022-09-22 01:59 Updated by: cazfi

• File 0026-Fix-dead-assignment-of-i-in-saving-multipliers-order.patch (File ID: 10354) is attached

2022-09-22 01:59 Updated by: cazfi

• Owner Update from (None) to cazfi
• Resolution Update from None to Accepted

2022-09-22 02:00 Updated by: cazfi

• Summary Updated

2022-09-27 13:05 Updated by: cazfi

• Status Update from Open to Closed
• Resolution Update from Accepted to Fixed