Dynamic city name length

• Reporter: cazfi
• Owner: cazfi
• Type: Patches
• Status: Closed
• Component: General
• MileStone: 3.1.0 (closed)
• Priority: 5 - Medium
• Severity: 5 - Medium
• Resolution: Fixed
• File: 1

Details Reply

Having MAX_LEN_CITYNAME space reserved for the city name in all city structures can be a bit wasteful. Worst case scenario is a server on a game with a huge number of cities AND players -> playermap of each player having all those cities.

Freeciv-web actually makes the MAX_LEN_CITYNAME shorter for this reason, causing one incompatibility and some unnecessary diff.

Ticket History (3/5 Histories)

2022-10-07 12:50 Updated by: cazfi

• New Ticket "Dynamic city name length" created

2022-10-13 02:47 Updated by: cazfi

• Milestone Update from 3.2.0 to 3.1.0 (closed)

Comment Reply

It actually makes sense to do this patch series (presumably three tickets) to S3_1, before npf.

2022-10-15 18:12 Updated by: cazfi

• File 0036-Make-city-name-allocation-dynamic.patch (File ID: 10586) is attached

2022-10-15 18:12 Updated by: cazfi

• Owner Update from (None) to cazfi
• Resolution Update from None to Accepted

2022-10-20 11:36 Updated by: cazfi

• Status Update from Open to Closed
• Resolution Update from Accepted to Fixed