PACKET_EDIT_CITY with unused trade[MAX_TRADE_ROUTES]

• Reporter: cazfi
• Owner: cazfi
• Type: Patches
• Status: Closed
• Component: General
• MileStone: S3_1 npf (closed)
• Priority: 5 - Medium
• Severity: 5 - Medium
• Resolution: Fixed
• File: 1

Details Reply

PACKET_EDIT_CITY has 'trade[MAX_TRADE_ROUTES]'. It's unused, and certainly won't be used in future either, as it doesn't really fit the freeciv-3.0+ idea of trade routes. Drop it.

Ticket History (3/4 Histories)

2022-10-14 11:22 Updated by: cazfi

• New Ticket "PACKET_EDIT_CITY with unused tradeMAX_TRADE_ROUTES" created

2022-10-14 11:25 Updated by: cazfi

• File 0038-Drop-trade-MAX_TRADE_ROUTES-from-PACKET_EDIT_CITY.patch (File ID: 10566) is attached

2022-10-14 11:25 Updated by: cazfi

• Owner Update from (None) to cazfi
• Resolution Update from None to Accepted
• Details Updated
• Summary Updated

2022-10-17 11:19 Updated by: cazfi

• Status Update from Open to Closed
• Resolution Update from Accepted to Fixed