Ticket #45860

installer_cross / Meson: Qt6-client build "error: '_WIN32_WINNT" redefined'

Open Date: 2022-10-14 19:17 Last Update: 2022-10-25 18:55

Reporter:
Owner:
Type:
Status:
Closed
Component:
MileStone:
Priority:
5 - Medium
Severity:
5 - Medium
Resolution:
Fixed
File:
1

Details

Building installer_cross / Meson Qt6-client with crosser from 2.5 branch (the branch is different from main, and current HEAD is already considered a crosser-2.5 candidate) gives

<command-line>: error: "_WIN32_WINNT" redefined [-Werror]
<command-line>: note: this is the location of the previous definition

Se it looks like in addition to our own _WIN32_WINNT definition we're inheriting one from somewhere else (presumably with pkg-config)

And that part of the command line is: "-D_WIN32_WINNT=0x0A00 -DWINVER=0x0A00"

Ticket History (3/5 Histories)

2022-10-14 19:17 Updated by: cazfi
  • New Ticket "installer_cross / Meson: Qt6-client build "error: '_WIN32_WINNT" redefined'" created
2022-10-14 21:03 Updated by: cazfi
Comment

Ok, Qt6 actually has Win10 as an official minimum requirement - earlier versions just didn't force it at compile time.

1) we need to make win10 the minimum requirement for Qt6-client, Qt6 modpack installer, and Qt6 ruledit (I think that will be what resolves this ticket; the build issue)
2) We can't drop Qt5 support from Windows environments etc, but instead implement that even to meson based builds. Relevant tickets to be created.

2022-10-21 09:28 Updated by: cazfi
  • Owner Update from (None) to cazfi
  • Resolution Update from None to Accepted
  • Milestone Update from (None) to 3.1.0 (closed)
  • Component Update from (None) to Bootstrap
Comment

Reply To cazfi

1) we need to make win10 the minimum requirement for Qt6-client, Qt6 modpack installer, and Qt6 ruledit (I think that will be what resolves this ticket; the build issue)

Attached patch handles that for Meson. We still need a new ticket for autotools.

2022-10-25 18:55 Updated by: cazfi
  • Status Update from Open to Closed
  • Resolution Update from Accepted to Fixed

Edit

Please login to add comment to this ticket » Login