effect_edit::comment_given() not setting empty comment

• Reporter: cazfi
• Owner: cazfi
• Type: Bugs
• Status: Closed
• Component: Ruledit and ruleup
• MileStone: 3.2.0
• Priority: 5 - Medium
• Severity: 5 - Medium
• Resolution: Fixed
• File: 1

Details

In case of empty comment from the user input, effect_edit::comment_given() frees the existing comment, but leaves the pointer. effect_edit::fill_active() then uses it.

Ticket History (3/4 Histories)

2022-12-05 17:35 Updated by: cazfi

• New Ticket "effect_edit::comment_given() not setting empty comment" created

2022-12-05 23:44 Updated by: cazfi

• File 0040-Ruledit-Fix-handling-of-empty-effect-comment.patch (File ID: 11034) is attached

2022-12-05 23:44 Updated by: cazfi

• Owner Update from (None) to cazfi
• Resolution Update from None to Accepted

2022-12-12 01:42 Updated by: cazfi

• Status Update from Open to Closed
• Resolution Update from Accepted to Fixed