load_action_names() overrides compat->version

• Reporter: cazfi
• Owner: cazfi
• Type: Bugs
• Status: Closed
• Component: Server
• MileStone: 3.2.0
• Priority: 5 - Medium
• Severity: 5 - Medium
• Resolution: Fixed
• File: 1

Details

load_action_names() sets compat->version. It ever should only check it (set already by load_game_names() ), and in case of freeciv-3.2 there's the additional complication that 3.1 did not have the file at all, so compat mode load does not find it from 3.1 directory.

Ticket History (3/4 Histories)

2022-12-25 04:54 Updated by: cazfi

• New Ticket "load_action_names() overrides compat->version" created

2022-12-25 05:45 Updated by: cazfi

• File 0035-Correct-load_action_names-ruleset-version-check.patch (File ID: 11202) is attached

2022-12-25 05:45 Updated by: cazfi

• Owner Update from (None) to cazfi
• Resolution Update from None to Accepted

2022-12-27 20:17 Updated by: cazfi

• Status Update from Open to Closed
• Resolution Update from Accepted to Fixed