Savegame: Stop saving zero counters lists

• Reporter: cazfi
• Owner: cazfi
• Type: Bugs
• Status: Closed
• Component: Server
• MileStone: 3.2.0
• Priority: 5 - Medium
• Severity: 5 - Medium
• Resolution: Fixed
• File: 1

Details

With current rulesets, with no counters defined, savegames still contain:

--

[counters]
c0=128
c1=127
c2=125
c3=131
c4=130
c5=126
c6=132
c7=129

--

Maybe we should omit saving those "lists" of counter values, when there's zero counters to save? That first element (present even with zero-lenght lists) is the city id, for which the list applies to.

Ticket History (3/6 Histories)

2023-01-10 05:50 Updated by: cazfi

• New Ticket "Savegame: Stop saving zero counters lists" created

2023-02-20 11:19 Updated by: cazfi

Comment

Verbose logging also gives an error related to this: "4: Warning: calloc with size 0 at line 2662 of ../../../src/server/savegame/savegame3.c"

2023-02-27 02:43 Updated by: lachu

• File 0001-OSDN-TICKET-46499-S-awomir-Lach-slawek-lach.art.pl.patch (File ID: 11730) is attached

2023-02-27 02:43 Updated by: lachu

Comment

Reply To cazfi

Verbose logging also gives an error related to this: "4: Warning: calloc with size 0 at line 2662 of ../../../src/server/savegame/savegame3.c"

2023-02-27 02:43 Updated by: lachu

File 0001-OSDN-TICKET-46499-S-awomir-Lach-slawek-lach.art.pl.patch (File ID: 11730) is attached

I think it was done.

2023-03-11 19:38 Updated by: cazfi

• Owner Update from (None) to cazfi
• Resolution Update from None to Accepted

2023-03-16 14:58 Updated by: cazfi

• Status Update from Open to Closed
• Resolution Update from Accepted to Fixed