adjust_improvement_wants_by_effects() does not know that considered building can provide also improvement flag

• Reporter: cazfi
• Owner: cazfi
• Type: Bugs
• Status: Closed
• Component: AI
• MileStone: 3.2.0
• Priority: 5 - Medium
• Severity: 5 - Medium
• Resolution: Fixed
• File: 2

Details

adjust_improvement_wants_by_effects() fails to see that the building under consideration might be fulfilling BuildingFlag requirement.

Ticket History (3/8 Histories)

2023-01-29 10:41 Updated by: cazfi

• New Ticket "adjust_improvement_wants_by_effects() does not know that considered building can provide also improvement flag" created

2023-01-29 10:53 Updated by: cazfi

Comment

dai_find_source_building() has similar problem.

2023-01-29 11:08 Updated by: cazfi

• File 0034-Fix-cases-where-AI-didn-t-consider-that-building-mig.patch (File ID: 11493) is attached

2023-01-29 11:08 Updated by: cazfi

• Owner Update from (None) to cazfi
• Resolution Update from None to Accepted

2023-01-29 20:34 Updated by: cazfi

• Resolution Update from Accepted to None

Comment

Current patch looks at wrong universal (not the requirement from the vector being iterated)

2023-01-30 07:30 Updated by: cazfi

• File 0024-Fix-cases-where-AI-didn-t-consider-that-building-mig.patch (File ID: 11505) is attached

2023-01-30 07:30 Updated by: cazfi

• Resolution Update from None to Accepted

2023-02-02 13:08 Updated by: cazfi

• Status Update from Open to Closed
• Resolution Update from Accepted to Fixed