I think the confusing part in civ2civ3 is that land in this case includes "Land" and "Big Land" classes, but not "Small Land".
My suggestion would be to include them all, so "Small Land" units do are fully restored by barracks, and the helptext could be changed to:
helptext = _("\
With a Barracks, each new MILITARY land unit built in a city will\
automatically have Veteran status, which means that its attack and\
defense strengths are increased by 50%.\
"), _("\
Also, damaged land units which stay in town for one full turn\
without moving are completely restored.\
")
Reply To bard
I think the confusing part in civ2civ3 is that land in this case includes "Land" and "Big Land" classes, but not "Small Land". My suggestion would be to include them all, so "Small Land" units do are fully restored by barracks
And similar change for Sun Tzu? I'm making a patch on that assumption at the moment.
Would these do?
Porting "Barracks" UnitClassFlag part also to S3_0 -> #47738
There are a couple of issue I'm going to check first:
- I forgot that Merchant class (Caravans) are also Land units that should recover HP from barracks
- Sun Tzu should not create experienced workers/engineers. I'm not sure if this patch would allow it
Reply To bard
- Sun Tzu should not create experienced workers/engineers. I'm not sure if this patch would allow it
Sun Tzu seems ok, because nonmil flag prevents it from happening.
- I forgot that Merchant class (Caravans) are also Land units that should recover HP from barracks
If you give the flag "Barracks" to Merchant class too, I think the patch will be more complete (including all land units).
Sorry me that I'm not doing this kind of patches. I'm afraid I can not work on freeciv the way I'd like to.
Reply To bard
If you give the flag "Barracks" to Merchant class too, I think the patch will be more complete (including all land units).
Done in a new version.
From https://www.hostedredmine.com/issues/857352 reported by chippo :
The help currently reads:
"With a Barracks, each new land unit built in a city will automatically have Veteran status, which means that its attack and defense strengths are increased by 50%. Also, damaged land units which stay in town for one full turn without moving are completely restored."
But that's not true for ALL land units.