Savegame: "unused entry" warnings about setting gamestart values

• Reporter: cazfi
• Owner: cazfi
• Type: Bugs
• Status: Closed
• Component: Server
• MileStone: 3.0.8 (closed)
• Priority: 5 - Medium
• Severity: 5 - Medium
• Resolution: Fixed
• File: 4

Details

Loading british-isles scenario on S3_1, with --warnings enabled:

...
1: data/scenarios/british-isles.sav.gz: unused entry: settings.set0.gamestart
1: data/scenarios/british-isles.sav.gz: unused entry: settings.set0.gamesetdef
1: data/scenarios/british-isles.sav.gz: unused entry: settings.set1.gamestart
1: data/scenarios/british-isles.sav.gz: unused entry: settings.set1.gamesetdef
...

Ticket History (3/9 Histories)

2023-03-24 03:42 Updated by: cazfi

• New Ticket "Savegame: "unused entry" warnings about setting gamestart values" created

2023-04-08 01:40 Updated by: cazfi

• Milestone Update from (None) to 3.0.8 (closed)

Comment

Such values should not get saved at all when game.server.settings_gamestart_valid is not true. Will open a new ticket about that.

But now that stable versions have been saving that information, we need to cleanly load them.

2023-04-08 02:10 Updated by: cazfi

Comment

Reply To cazfi

Such values should not get saved at all when game.server.settings_gamestart_valid is not true. Will open a new ticket about that.

-> #47793

2023-04-22 22:31 Updated by: cazfi

• File 0027-Savegame-Silence-unused-entry-warnings-about-gamesta.patch (File ID: 12251) is attached

2023-04-22 22:31 Updated by: cazfi

• File 0022-Savegame-Silence-unused-entry-warnings-about-gamesta.patch (File ID: 12252) is attached

2023-04-22 22:31 Updated by: cazfi

• File 0049-Savegame-Silence-unused-entry-warnings-about-gamesta.patch (File ID: 12253) is attached

2023-04-22 22:31 Updated by: cazfi

• File 0035-Savegame-Silence-unused-entry-warnings-about-gamesta.patch (File ID: 12254) is attached

2023-04-22 22:32 Updated by: cazfi

• Owner Update from (None) to cazfi
• Resolution Update from None to Accepted

2023-04-26 07:19 Updated by: cazfi

• Status Update from Open to Closed
• Resolution Update from Accepted to Fixed