activity_to_extra_rmcause() does not consider ACTIVITY_CLEAN

• Reporter: cazfi
• Owner: cazfi
• Type: Bugs
• Status: Closed
• Component: General
• MileStone: 3.2.0
• Priority: 5 - Medium
• Severity: 5 - Medium
• Resolution: Fixed
• File: 1

Details

activity_to_extra_rmcause() treats ACTIVITY_CLEAN like it would not remove any extras, whereas it actually would remove *both* ERM_CLEANPOLLUTION and ERM_CLEANFALLOUT

Ticket History (3/4 Histories)

2023-04-11 03:45 Updated by: cazfi

• New Ticket "activity_to_extra_rmcause() does not consider ACTIVITY_CLEAN" created

2023-04-14 03:27 Updated by: cazfi

• File 0050-Add-ERM_CLEAN.patch (File ID: 12180) is attached

2023-04-14 03:31 Updated by: cazfi

Comment

Attached patch adds the new ERM_CLEAN extra removal cause at this point of "Clean Pollution/Clean Fallout" -> "Clean" migration already, and makes activity_to_extra_rmcause() to return that for ACTIVITY_CLEAN.

Supplied rulesets temporarily have both ERM_CLEAN and ERM_CLEANPOLLUTION/ERM_CLEANFALLOUT for all cleanable extras, and I guess any custom ruleset wanting to be compatible with this specific point of freeciv development need to do the same.

2023-04-22 06:39 Updated by: cazfi

• Status Update from Open to Closed
• Owner Update from (None) to cazfi
• Resolution Update from None to Fixed