Ticket #47891

sdl2: Dead 'pBuf' assignments in diplodlg.c

Open Date: 2023-04-22 00:55 Last Update: 2023-04-24 08:51

Reporter:
Owner:
Type:
Status:
Closed
Component:
MileStone:
Priority:
5 - Medium
Severity:
5 - Medium
Resolution:
Fixed
File:
2

Details

As clang analyzer reports, sdl2-client two S3_0 diplodlg.c functions assign t 'pBuf' only to overwrite with a new value a bit later, and not using it in between. Functions are popup_war_dialog() (line 1431) and popup_diplomacy_dialog() (line 1636)

Ticket History (3/5 Histories)

2023-04-22 00:55 Updated by: cazfi
  • New Ticket "sdl2: Dead 'pBuf' assignments in diplodlg.c" created
2023-04-22 01:06 Updated by: cazfi
  • Owner Update from (None) to cazfi
  • Resolution Update from None to Accepted
2023-04-24 08:51 Updated by: cazfi
  • Status Update from Open to Closed
  • Resolution Update from Accepted to Fixed

Edit

Please login to add comment to this ticket » Login