Ticket #47927

Round "Trade_Revenue_Bonus" logarithms down

Open Date: 2023-04-24 17:10 Last Update: 2024-02-23 08:03

Reporter:
Owner:
(None)
Type:
Status:
Open
Component:
MileStone:
Priority:
5 - Medium
Severity:
5 - Medium
Resolution:
None
File:
None

Details

In all instances of "Trade_Revenue_Bonus", replace 585 on 584, 1585 on 1584, 1000 on 999 and -1000 on -1001. That should allow to get the values expected more often since we round the results of applying this effects up, and 20.001 - 1 < 1 / 1442 that likely won't ever reduce expected revenue bonus at 1.

Ticket History (3/6 Histories)

2023-04-24 17:10 Updated by: ihnatus
  • New Ticket "Round "Trade_Revenue_Bonus" logarithms down" created
2023-04-24 17:11 Updated by: ihnatus
  • Details Updated
2023-06-30 21:07 Updated by: cazfi
2023-09-03 04:26 Updated by: cazfi
Comment

Can you make a patch?

I was about to do one quickly, but then realized that one needs to consider how those values are supposed to cancel each other (e.g. when should (585) + (-585) be turned to (584) + (-584))

Retargeting to 3.1. Don't want to change 3.0 rules balance for final releases from the series.

2023-12-29 07:00 Updated by: cazfi
2024-02-23 08:03 Updated by: cazfi

Attachment File List

No attachments

Edit

You are not logged in. I you are not logged in, your comment will be treated as an anonymous post. » Login