dai_process_defender_want() desire 'int' to fabs()

• Reporter: cazfi
• Owner: cazfi
• Type: Bugs
• Status: Closed
• Component: AI
• MileStone: 3.0.8 (closed)
• Priority: 6
• Severity: 5 - Medium
• Resolution: Fixed
• File: 1

Details Reply

S3_0 build fails on Suse Leap. It doesn't like the fact that fabs() gets an non-float parameter on dai_process_defender_want().

I guess it's referring to 'desire' being an int, and that looks like real bug to me (definitely should support non-integer values)

Ticket History (3/5 Histories)

2023-04-28 02:32 Updated by: cazfi

• New Ticket "dai_process_defender_want() desire 'int' to fabs()" created

2023-04-28 14:07 Updated by: cazfi

• Priority Update from 5 - Medium to 6

2023-04-29 04:30 Updated by: cazfi

• File 0021-Fix-build-with-clang.patch (File ID: 12315) is attached

2023-04-29 04:30 Updated by: cazfi

• Owner Update from (None) to cazfi
• Resolution Update from None to Accepted

Comment Reply

- More a "clang issue" than "Suse Leap issue" - seen on other environments since original report
- Only S3_0 affeced. Later branches (from where this was backported) have those variables as floats
- I've concluded that right thing to do (in S3_0 - if other branches affected would have been affected, they could have had different fix) is to do partial revert of osdn #47901

Patch attached.

2023-05-01 21:09 Updated by: cazfi

• Status Update from Open to Closed
• Resolution Update from Accepted to Fixed