savegame3: Drop fit_nationset_to_players() call

• Reporter: cazfi
• Owner: cazfi
• Type: Patches
• Status: Closed
• Component: Server
• MileStone: 3.0.9 (closed)
• Priority: 5 - Medium
• Severity: 5 - Medium
• Resolution: Fixed
• File: 2

Details

fit_nationset_to_players() :

To be called when loading an old savegame that predates nationsets.

Grepping shows that savegame3.c has a call, though the nationsets were in use by the time savegame3 format was first introduced.

Ticket History (3/9 Histories)

2023-06-21 15:03 Updated by: cazfi

• New Ticket "savegame3: Drop fit_nationset_to_players() call" created

2023-06-23 15:51 Updated by: cazfi

• Milestone Update from (None) to 3.0.9 (closed)

2023-09-25 05:08 Updated by: cazfi

Comment

Actually I think we still need this as a savegame sanity measure, e.g., to make sure that ruleset changes between saving and loading have not broken things.

So, I think this should be resolved by updating comments, both fit_nationset_to_players() side and the calling side.

2023-09-25 05:14 Updated by: cazfi

• File 0048-Improve-fit_nationset_to_players-comments.patch (File ID: 13312) is attached

2023-09-25 05:18 Updated by: cazfi

• File 0016-Improve-fit_nationset_to_players-comments.patch (File ID: 13313) is attached

2023-09-25 05:22 Updated by: cazfi

• File 0016-Improve-fit_nationset_to_players-comments.patch (File ID: 13314) is attached

2023-09-25 05:24 Updated by: cazfi

• File 0016-Improve-fit_nationset_to_players-comments.patch (File ID: 13314) is deleted

2023-09-25 05:32 Updated by: cazfi

• Owner Update from (None) to cazfi
• Resolution Update from None to Accepted

2023-09-28 20:23 Updated by: cazfi

• Status Update from Open to Closed
• Resolution Update from Accepted to Fixed