Qt: help_widget::uclass_max_values() not initializing convert_time

• Reporter: cazfi
• Owner: cazfi
• Type: Bugs
• Status: Closed
• Component: Qt-client
• MileStone: 3.0.9 (closed)
• Priority: 5 - Medium
• Severity: 5 - Medium
• Resolution: Fixed
• File: 1

Details

S3_1, clang-16 analyzer:

../../../../src/client/gui-qt/helpdlg.cpp:1684:7: warning: The left operand of '>' is a garbage value [core.UndefinedBinaryOperatorResult]
      SET_MAX(convert_time);
      ^~~~~~~~~~~~~~~~~~~~~
../../../../src/client/gui-qt/helpdlg.cpp:1679:23: note: expanded from macro 'SET_MAX'
      max->v = max->v > utype->v ? max->v : utype->v

Ticket History (3/4 Histories)

2023-07-10 10:43 Updated by: cazfi

• New Ticket "Qt: help_widget::uclass_max_values() not initializing convert_time" created

2023-07-10 11:42 Updated by: cazfi

• File 0019-Qt-help_widget-uclass_max_values-Initialize-convert_.patch (File ID: 12854) is attached

2023-07-10 12:36 Updated by: cazfi

• Owner Update from (None) to cazfi
• Resolution Update from None to Accepted
• Milestone Update from (None) to 3.0.9 (closed)

Comment

Patch for all branches, including S2_6, attached.

2023-07-15 13:46 Updated by: cazfi

• Status Update from Open to Closed
• Resolution Update from Accepted to Fixed