sdl2: real_info_city_report_dialog_update() unused 'w' value

• Reporter: cazfi
• Owner: cazfi
• Type: Bugs
• Status: Closed
• Component: SDL2-client
• MileStone: 3.0.9 (closed)
• Priority: 5 - Medium
• Severity: 5 - Medium
• Resolution: Fixed
• File: 2

Details

The last value real_info_city_report_dialog_update() sets to 'w' is never used.
Clang analyzer, S3_1:

../../../../src/client/gui-sdl2/cityrep.c:827:3: warning: Value stored to 'w' is never read [deadcode.DeadStores]
  w += adj_size(2);
  ^    ~~~~~~~~~~~

Ticket History (3/5 Histories)

2023-08-26 23:13 Updated by: cazfi

• New Ticket "sdl2: real_info_city_report_dialog_update() unused 'w' value" created

2023-08-26 23:43 Updated by: cazfi

• File 0010-sdl2-Fix-cityrep.c-unused-w-clang-analyzer-warning.patch (File ID: 13068) is attached

2023-08-26 23:45 Updated by: cazfi

• File 0007-sdl2-Fix-cityrep.c-unused-w-clang-analyzer-warning.patch (File ID: 13069) is attached

2023-08-26 23:51 Updated by: cazfi

• Owner Update from (None) to cazfi
• Resolution Update from None to Accepted

2023-08-28 22:53 Updated by: cazfi

• Status Update from Open to Closed
• Resolution Update from Accepted to Fixed