dai_select_tech() clang analyzer warning about garbage goal_values[i]

• Reporter: cazfi
• Owner: cazfi
• Type: Bugs
• Status: Closed
• Component: AI
• MileStone: 3.0.9 (closed)
• Priority: 5 - Medium
• Severity: 5 - Medium
• Resolution: Fixed
• File: 2

Details

S3_1, clang analyzer:

../../../../src/ai/default/aitech.c:174:26: warning: The left operand of '>' is a garbage value [core.UndefinedBinaryOperatorResult]
      if (goal_values[i] > goal_values[newgoal]

This was partly fixed by #47959, but not completely

Ticket History (3/5 Histories)

2023-09-17 00:49 Updated by: cazfi

• New Ticket "dai_select_tech() clang analyzer warning about garbage goal_valuesi" created

2023-09-17 00:57 Updated by: cazfi

• File 0020-dai_select_tech-Get-advance_count-just-once.patch (File ID: 13205) is attached

2023-09-17 00:59 Updated by: cazfi

• File 0012-dai_select_tech-Get-advance_count-just-once.patch (File ID: 13206) is attached

2023-09-17 01:12 Updated by: cazfi

• Owner Update from (None) to cazfi
• Resolution Update from None to Accepted
• Summary Updated

Comment

Bugfix for S3_0 & S3_1 attached. Later branches are not affected, but small part of the patch ported for optimization reasons.

2023-09-18 13:22 Updated by: cazfi

• Status Update from Open to Closed
• Resolution Update from Accepted to Fixed