sdl2: helpdlg.c NULL advance_label

• Reporter: cazfi
• Owner: cazfi
• Type: Bugs
• Status: Closed
• Component: SDL2-client
• MileStone: 3.1.0 (closed)
• Priority: 5 - Medium
• Severity: 5 - Medium
• Resolution: Fixed
• File: 6

Details

S3_1, clang analyzer:

../../../../src/client/gui-sdl2/helpdlg.c:2079:23: warning: Access to field 'next' results in a dereference of a null pointer (loaded from variable
'advance_label') [core.NullDereference]
      advance_label = advance_label->next;

Ticket History (3/11 Histories)

2023-09-21 18:49 Updated by: cazfi

• New Ticket "sdl2: helpdlg.c NULL advance_label" created

2023-09-21 18:57 Updated by: cazfi

• Details Updated

2024-02-08 04:47 Updated by: cazfi

• File 0038-sdl2-3-Fix-NULL-dereference-in-popup_tech_info.patch (File ID: 13688) is attached

2024-02-08 04:47 Updated by: cazfi

• File 0010-sdl2-Fix-NULL-dereference-in-popup_tech_info.patch (File ID: 13689) is attached

2024-02-08 04:47 Updated by: cazfi

• File 0019-sdl-2-Fix-NULL-dereference-in-popup_tech_info.patch (File ID: 13690) is attached

2024-02-08 04:48 Updated by: cazfi

• Owner Update from (None) to cazfi
• Resolution Update from None to Accepted
• Milestone Update from (None) to 3.1.0 (closed)

Comment

Patch also for S2_6 (but not for S3_0)

2024-02-08 05:01 Updated by: cazfi

• File 0038-sdl2-3-Fix-NULL-dereference-in-popup_tech_info.patch (File ID: 13691) is attached

2024-02-08 05:01 Updated by: cazfi

• File 0010-sdl2-Fix-NULL-dereference-in-popup_tech_info.patch (File ID: 13692) is attached

2024-02-08 05:01 Updated by: cazfi

• File 0019-sdl-2-Fix-NULL-dereference-in-popup_tech_info.patch (File ID: 13693) is attached

2024-02-08 05:02 Updated by: cazfi

Comment

- Fixed advance-off-by-one error

2024-02-14 05:21 Updated by: cazfi

• Status Update from Open to Closed
• Resolution Update from Accepted to Fixed