Incorrect types passed as API_TYPE_INT

• Reporter: cazfi
• Owner: cazfi
• Type: Bugs
• Status: Closed
• Component: Scripting API
• MileStone: 3.0.9 (closed)
• Priority: 5 - Medium
• Severity: 5 - Medium
• Resolution: Fixed
• File: 2

Details

We've encountered issues with wrong kind of types being passed to lua signals and functions as API_TYPE_INT in the past. I believe them all to be broken in practice, even if no script has exposed those bugs in a serious way.

Make sure to cast all values passed as API_TYPE_INT as lua_Integer to make sure they are correct no matter C-side type width on the specific host and/or lua-side width.

Ticket History (3/6 Histories)

2023-09-25 00:48 Updated by: cazfi

• New Ticket "Incorrect types passed as API_TYPE_INT" created

2023-09-25 00:56 Updated by: cazfi

• File 0045-Lua-Always-pass-lua_Integer-to-API_TYPE_INT.patch (File ID: 13308) is attached

2023-09-25 01:03 Updated by: cazfi

• File 0015-Lua-Always-pass-lua_Integer-to-API_TYPE_INT.patch (File ID: 13309) is attached

2023-09-25 01:09 Updated by: cazfi

• Owner Update from (None) to cazfi
• Resolution Update from None to Accepted

2023-09-30 12:46 Updated by: cazfi

Comment

Pushed to branches other than S3_1, where this did not apply at the moment (must have textual dependency to some other patch earlier in my work branch)

2023-09-30 13:25 Updated by: cazfi

• Status Update from Open to Closed
• Resolution Update from Accepted to Fixed