tile_move_cost_ptrs() compile failure on arm32

• Reporter: cazfi
• Owner: cazfi
• Type: Bugs
• Status: Closed
• Component: General
• MileStone: 3.0.9 (closed)
• Priority: 5 - Medium
• Severity: 5 - Medium
• Resolution: Fixed
• File: 1

Details

S3_1, OpenEmbedded arm32 target:

| ../../git/common/map.c: In function 'tile_move_cost_ptrs':
| ../../git/common/map.c:838:31: error: comparison is always false due to limited range of data type [-Werror=type-limits]
|   838 |             if (cardinal_move < 0) {
|       |                               ^
| ../../git/common/map.c:882:23: error: comparison is always false due to limited range of data type [-Werror=type-limits]
|   882 |     if (cardinal_move < 0) {
|       |                       ^

Ticket History (3/4 Histories)

2023-09-28 05:12 Updated by: cazfi

• New Ticket "tile_move_cost_ptrs() compile failure on arm32" created

2023-09-28 05:18 Updated by: cazfi

• File 0036-tile_move_cost_ptrs-Make-cardinal_move-signed.patch (File ID: 13347) is attached

2023-09-28 05:18 Updated by: cazfi

• Owner Update from (None) to cazfi
• Resolution Update from None to Accepted

Comment

Patch meant also to S2_6 attached.

2023-09-29 17:44 Updated by: cazfi

• Status Update from Open to Closed
• Resolution Update from Accepted to Fixed