For2.2.2-Refactoring: angband_sound_name replacement

• Reporter: backwardseric
• Owner: deskull
• Type: Support Request
• Status: Closed
• Component: (None)
• MileStone: 変愚蛮怒3.0.0alphaリリース (closed)
• Priority: 3
• Severity: 3
• Resolution: Fixed
• File: None

Details

The removal of angband_sound_name as a global in the For2.2.2-Refactoring branch looks like it will lead to repetition of code (i.e. the definition of angband_sound_name currently in main_win.c) for every front end that wants to support sound. Would it be possible to restore angband_sound_name as a global or introduce a replacement interface which would allow front ends to support sound without each having to repeat the list of standard sound names?

Ticket History (3/5 Histories)

2020-01-22 02:27 Updated by: backwardseric

• New Ticket "For2.2.2-Refactoring: angband_sound_name replacement" created

2020-01-23 01:01 Updated by: deskull

• Milestone Update from (None) to 変愚蛮怒3.0.0正式リリース (closed)
• Owner Update from (None) to deskull

2020-01-25 21:42 Updated by: deskull

Comment

I see. Now 'angband_sound_name' is only in main-win.c and main-x11.c. Therefore how about unifying those and moving to util.c/h?

2020-07-08 02:22 Updated by: backwardseric

• Status Update from Open to Closed

Comment

Thanks for main/sound-definitions-table.h which satisfies the initial request. I've closed the ticket.

2021-01-02 09:53 Updated by: deskull

• Milestone Update from 変愚蛮怒3.0.0正式リリース (closed) to 変愚蛮怒3.0.0alphaリリース (closed)
• Resolution Update from None to Fixed