WORLD_SCORE not set: save/save.c missing prototypes

• Reporter: backwardseric
• Owner: habu
• Type: Patches
• Status: Closed
• Component: (None)
• MileStone: 変愚蛮怒3.0.0Alpha5リリース (closed)
• Priority: 1 - Lowest
• Severity: 1 - Lowest
• Resolution: Duplicate
• File: None

Details

When WORLD_SCORE is not set, io/report.h does not include io/files-util.h. Since save/save.c uses savefile, debug_savefile, and counts_write() from io/files-util.h, compiling save/save.c with the clang compiler (version 12) and WORLD_SCORE not set leads to compiler errors for missing prototypes for the symbols declared in io/report.h.

This commit, https://osdn.net/projects/hengbandforosx/scm/git/hengbandosx/commits/e159659d0216e44aed597dc25623bef8f7d797f4 , (clang-save-missing-prototypes branch on the hengbandforosx project; branch is based off Hengband's develop branch) always includes io/files-util.h in save/save.c so those prototypes are available regardless of the setting for WORLD_SCORE.

Ticket History (3/3 Histories)

2021-02-06 06:52 Updated by: backwardseric

• New Ticket "WORLD_SCORE not set: save/save.c missing prototypes" created

2021-02-06 15:42 Updated by: habu

• Status Update from Open to Closed
• Resolution Update from None to Duplicate

Comment

I had noticed this problem some time ago and had created a ticket #41444 for this issue.

Your series of commits (tickets #41480 #41481 #41482) will be taken in and this issue will be dealt with in ticket #41444.

Thank you.

2021-02-06 21:26 Updated by: deskull

• Owner Update from (None) to habu
• Milestone Update from (None) to 変愚蛮怒3.0.0Alpha5リリース (closed)