Ticket #44580

generate_packets.py: make Field.__init__ assign variables explicitly

Open Date: 2022-05-13 23:11 Last Update: 2022-05-16 21:42

Reporter:
Owner:
Type:
Status:
Closed
Component:
MileStone:
Priority:
5 - Medium
Severity:
5 - Medium
Resolution:
Fixed
File:
1

Details

Part of #43927. The Field class's initializer currently assigns data passed in by parse_fields() to the instance's __dict__ directly, which makes it impossible for static code checkers to reason about what members Field objects even have. Each instance variable should be assigned explicitly instead.

Ticket History (3/4 Histories)

2022-05-13 23:11 Updated by: alienvalkyrie
  • New Ticket "generate_packets.py: make Field.__init__ assign variables explicitly" created
2022-05-13 23:15 Updated by: alienvalkyrie
  • Resolution Update from None to Accepted
Comment

Attached patch should be independent of other currently pending patches.

2022-05-16 21:42 Updated by: alienvalkyrie
  • Status Update from Open to Closed
  • Resolution Update from Accepted to Fixed

Edit

Please login to add comment to this ticket » Login