Ticket #44585

generate_packets.py: assertions should be errors

Open Date: 2022-05-14 04:53 Last Update: 2022-05-16 22:24

Reporter:
Owner:
Type:
Status:
Closed
Component:
MileStone:
Priority:
5 - Medium
Severity:
5 - Medium
Resolution:
Fixed
File:
1

Details

Part of #43927. Current generate_packets.py contains a lot of assert statements, which only get run when __debug__ is true – most of these check the integrity of outside input (packets.def) and should thus raise ValueErrors instead.

Ticket History (3/4 Histories)

2022-05-14 04:53 Updated by: alienvalkyrie
  • New Ticket "generate_packets.py: assertions should be errors" created
2022-05-14 05:38 Updated by: alienvalkyrie
  • Resolution Update from None to Accepted
2022-05-16 22:24 Updated by: alienvalkyrie
  • Status Update from Open to Closed
  • Resolution Update from Accepted to Fixed

Edit

Please login to add comment to this ticket » Login