Ticket #44975

generate_packets.py: remove no-packet flag

Open Date: 2022-07-02 06:03 Last Update: 2022-07-03 21:34

Reporter:
Owner:
Type:
Status:
Closed
Component:
MileStone:
Priority:
5 - Medium
Severity:
5 - Medium
Resolution:
Fixed
File:
2

Details

Part of #43927. The packet flag no-packet produces send methods that do not take a packet struct as argument. Such code is only valid for packets with no fields (e.g. PACKET_SERVER_SHUTDOWN), in which case the flag is automatically added anyway. It has also never been explicitly added to a packet since the delta protocol was first committed.

~> remove it as a settable flag (while keeping the "empty packet send methods take no packet struct" behavior).

Ticket History (3/7 Histories)

2022-07-02 06:03 Updated by: alienvalkyrie
  • New Ticket "generate_packets.py: remove no-packet flag" created
2022-07-02 06:29 Updated by: alienvalkyrie
  • Resolution Update from None to Accepted
2022-07-02 07:19 Updated by: alienvalkyrie
  • Resolution Update from Accepted to None
Comment

Still need to remove mentions in packets.def comments

2022-07-02 07:23 Updated by: alienvalkyrie
  • Resolution Update from None to Accepted
2022-07-03 21:34 Updated by: alienvalkyrie
  • Status Update from Open to Closed
  • Resolution Update from Accepted to Fixed

Edit

Please login to add comment to this ticket » Login