Ticket #46306

pf_attack_possible() int-conversion warning

Open Date: 2022-12-18 08:08 Last Update: 2023-01-02 12:32

Reporter:
Owner:
Type:
Status:
Closed
Component:
MileStone:
Priority:
5 - Medium
Severity:
5 - Medium
Resolution:
Fixed
File:
2

Details

Testing with gcc-13 in c2x (likely c23) standard mode: S3_1 pf_attack_possible() assignment from is_non_allied_city_tile() to non_allied_city gives error about converting pointer to int.

Ticket History (3/7 Histories)

2022-12-18 08:08 Updated by: cazfi
  • New Ticket "pf_attack_possible() int-conversio warning" created
2022-12-18 08:08 Updated by: cazfi
  • Summary Updated
2022-12-20 13:11 Updated by: None
Comment

The problem is that unlike their name suggest is_..._city_tile() functions return a pointer, not a boolean. That has worked under earlier C standard versions.

2022-12-29 11:14 Updated by: cazfi
  • Owner Update from (None) to cazfi
  • Resolution Update from None to Accepted
  • Milestone Update from (None) to 3.0.6 (closed)
Comment

No S2_6 patch yet - have to confirm if one is needed. Review period for later branches running anyway.

2023-01-02 12:32 Updated by: cazfi
  • Status Update from Open to Closed
  • Resolution Update from Accepted to Fixed

Edit

Please login to add comment to this ticket » Login