allura
Fork

Commit

[#3852] Fixed Fixed unicode encode error when generating gravitar IDs

Signed-off-by: Cory Johns <johnsca@geek.net>

--- a/Allura/allura/lib/gravatar.py

+++ b/Allura/allura/lib/gravatar.py

		@@ -14,7 +14,7 @@ def id(email):
14	14	match = _wrapped_email.match(email)
15	15	if match:
16	16	email = match.group(1)
17		- return hashlib.md5(email.strip().lower()).hexdigest()
	17	+ return hashlib.md5(email.strip().lower().encode('utf8')).hexdigest()
18	18
19	19	def url(email=None, gravatar_id=None, **kw):
20	20	"""Build a complete gravatar URL with our favorite defaults.

--- a/Allura/allura/tests/functional/test_gravatar.py

+++ b/Allura/allura/tests/functional/test_gravatar.py

		@@ -12,6 +12,12 @@ class TestGravatar(TestController):
12	12	actual_id = gravatar.id(email)
13	13	assert expected_id == actual_id
14	14
	15	+ def test_unicode_id(self):
	16	+ email = u'Vin\u00EDcius@example.com'
	17	+ expected_id = 'e00968255d68523b034a6a39c522efdb'
	18	+ actual_id = gravatar.id(email)
	19	+ assert expected_id == actual_id, 'Expected gravitar ID %s, got %s' % (repr(expected_id), repr(actual_id))
	20	+
15	21	def test_url(self):
16	22	email = 'Wolf@example.com'
17	23	expected_id = 'd3514940ac1b2051c8aa42970d17e3fe'