#42594: Units on Rally-point GOTO don't show 'G' icon for goto status
Open Date: 2021-07-02 09:50
Last Update: 2021-07-05 13:41
URL for this Ticket:
https://osdn.net//projects/freeciv/ticket/42594
RSS feed for this Ticket:
https://osdn.net/ticket/ticket_rss.php?group_id=12505&tid=42594
---------------------------------------------------------------------
Last Changes/Comment on this Ticket:
2021-07-05 13:41 Updated by: lexxie9952
Comment:
Fixed here:
https://github.com/Lexxie9952/fcw.org-server/commit/329cba20b8a214a502e677de29a57cbe19ab7950
Adding dest_tile to rally points and rally packets fixes this AND lets clients know and report the city's rally point.
Note: there is a FIXME comment in there for servers who don't want to add the dest_tile field. In there is a previous and working hacky-patch that fixes some issues without adding the dest_tile.
However, that means they can't set the punit->goto_tile correctly though, which will surely make issues. The commit as it currently stands, resolves all issues.
Feel free to cherry pick. If alternate solution implemented please notify me. Thanks
NOTE:
Changes network protocol but not savegame compat.
---------------------------------------------------------------------
Ticket Status:
Reporter: lexxie9952
Owner: (None)
Type: Bugs
Status: Open
Priority: 5 - Medium
MileStone: (None)
Component: (None)
Severity: 5 - Medium
Resolution: None
---------------------------------------------------------------------
Ticket details:
When a unit is sent on GOTO because of a city rally point, if the GOTO dest_tile is more than one turn away, the unit will not show in the client with a 'G' to indicate it is still under an active not-yet-completed GOTO order.
Brief investigation of the issue discovered that the separate goto_tile field is not being set when a unit begins executing the movement of its rally point order.
--
Ticket information of Freeciv project
Freeciv Project is hosted on OSDN
Project URL: https://osdn.net/projects/freeciv/
OSDN: https://osdn.net
URL for this Ticket:
https://osdn.net/projects/freeciv/ticket/42594
RSS feed for this Ticket:
https://osdn.net/ticket/ticket_rss.php?group_id=12505&tid=42594