#42993: Wonders needlessly hard-coded to override the building upkeep specified in the ruleset.
Open Date: 2021-10-07 19:09
Last Update: 2022-01-06 06:03
URL for this Ticket:
https://osdn.net//projects/freeciv/ticket/42993
RSS feed for this Ticket:
https://osdn.net/ticket/ticket_rss.php?group_id=12505&tid=42993
---------------------------------------------------------------------
Last Changes/Comment on this Ticket:
2022-01-06 06:03 Updated by: lexxie9952
Comment:
So this seems to be angled toward not allowing upkeep unless a building is sellable.
I am not sure if this is following a plan for compatibility with FCW and MP2 rulesets.
In particular, we have a wonder with negative upkeep (Hoover Dam) which relieves upkeep for other buildings in its own city.
I believe I see the case that bothers you. Someone has negative upkeep and here is no other building to sell that's left except a wonder.
Disallowing wonder upkeep for this almost never occurring case, it's not ideal. But I suppose you are thinking a special flag for wonders with upkeep that if they have positive upkeep they must be sellable. As ruleset designer I should have liked a discussion on where we might go with it.
---------------------------------------------------------------------
Ticket Status:
Reporter: lexxie9952
Owner: (None)
Type: Bugs
Status: Open
Priority: 5 - Medium
MileStone: (None)
Component: (None)
Severity: 5 - Medium
Resolution: None
---------------------------------------------------------------------
Ticket details:
This bug was probably never found because the vast majority of wonders have 0 upkeep.
However, rulesets allow the ruleset designer to set the upkeep for any building or wonder.
There is no need for the server to hard-code 0 upkeep for wonders to override the ruleset values.
file: city.js
function: int city_improvement_upkeep(const struct city *pcity, const struct impr_type *b)
blamed lines:
if (is_wonder(b)) {
return 0;
}
--
Ticket information of Freeciv project
Freeciv Project is hosted on OSDN
Project URL: https://osdn.net/projects/freeciv/
OSDN: https://osdn.net
URL for this Ticket:
https://osdn.net/projects/freeciv/ticket/42993
RSS feed for this Ticket:
https://osdn.net/ticket/ticket_rss.php?group_id=12505&tid=42993