Drop checks whether unit should be in game

• Reporter: cazfi
• Owner: cazfi
• Type: Patches
• Status: Closed
• Component: General
• MileStone: 3.2.0
• Priority: 5 - Medium
• Severity: 5 - Medium
• Resolution: Fixed
• File: 1

Details Reply

Freeciv code often checks if unit tech req is A_NEVER, indicating that the unit isn't in the game at all.

That's relic from the time (obsolete at least 20 years) units were in a static array with fixed order, and those in the middle had to be marked as removed that way. With the current dynamically filled array we don't insert such units at all, and those checks are obsolete.

Get rid of them. Such a use of unit required_advance is also one of the bigger remaining blockers against #44927

Ticket History (3/5 Histories)

2022-07-05 11:21 Updated by: cazfi

• New Ticket "Drop checks whether unit should be in game" created

2022-07-16 20:49 Updated by: cazfi

Comment Reply

Concern regarding savegame compatibility came up for similar "Never" support of techs: https://osdn.net/projects/freeciv/ticket/45115#comment:12505:45115:1657972075

2022-07-19 02:25 Updated by: cazfi

• File 0057-Drop-checks-if-a-valid-unit-isn-t-in-game.patch (File ID: 9844) is attached

2022-07-19 02:25 Updated by: cazfi

• Owner Update from (None) to cazfi
• Resolution Update from None to Accepted

Comment Reply

Reply To cazfi

Concern regarding savegame compatibility came up for similar "Never" support of techs: https://osdn.net/projects/freeciv/ticket/45115#comment:12505:45115:1657972075

In case of units, it was already impossible to get such units to the game (prevented ruleset load time), and there are flags that can be used to mark unit as unbuildable etc.

2022-07-28 11:34 Updated by: cazfi

• Status Update from Open to Closed
• Resolution Update from Accepted to Fixed