Part of #43927. Some code is unnecessarily duplicated between Packets and Variants. Remove the fields and members of the Variant class that are only used on Packets, or that can be taken unmodified from the packet this is a variant of.

Ticket History (3/4 Histories)

2022-06-07 02:57 Updated by: alienvalkyrie

New Ticket "generate_packets.py: remove Variant members only needed on Packets" created

2022-06-07 05:15 Updated by: alienvalkyrie

File 0009-generate_packets.py-remove-superfluous-Variant-membe.patch (File ID: 9421) is attached

2022-06-07 05:16 Updated by: alienvalkyrie

Resolution Update from None to Accepted

Comment

Reply To alienvalkyrie

or that can be taken unmodified from the packet this is a variant of.

This patch leaves some of those fields in if they are used in a lot of places – those should be turned into properties in #44768.

2022-06-08 20:21 Updated by: alienvalkyrie

Status Update from Open to Closed
Resolution Update from Accepted to Fixed

Attachment File List

0009-generate_packets.py-remove-superfluous-Variant-membe.patch(3KB)
- master

Freeciv

Ticket #44765 Ticket List Submit New Ticket RSS

generate_packets.py: remove Variant members only needed on Packets Open Date: 2022-06-07 02:57 Last Update: 2022-06-08 20:21 monitor ON OFF

Details

Ticket History (3/4 Histories) Show older Histories