Freeciv

Reply To cazfi

Add lua method to get city counter value, e.g., "Counter:get_value(City)". Depends on #47827

I think it is done. Maybe reuse code from scenario? Scenario to conquer city and kept it for some time is great fun, but scenario should be modified, like time of keeping control over city to achieve victory, making default owner of Constantinopol a barbarian player, etc.

Reply To cazfi

Add lua method to get city counter value, e.g., "Counter:get_value(City)". Depends on #47827

I think it is done. Maybe reuse code from scenario? Scenario to conquer city and kept it for some time is great fun, but scenario should be modified, like time of keeping control over city to achieve victory, making default owner of Constantinopol a barbarian player, etc.

The patch tries to modify file server/scripting/api_server_counters.c that does not exist.

Likely this method (to READ counter value) should be in the common/ code. Also the client knows the counter values.

Reply To cazfi

The patch tries to modify file server/scripting/api_server_counters.c that does not exist.

That's being added by #47828

But this is still valid point:

Likely this method (to READ counter value) should be in the common/ code. Also the client knows the counter values.

Reply To cazfi

Reply To cazfi

The patch tries to modify file server/scripting/api_server_counters.c that does not exist.

That's being added by #47828 But this is still valid point:

Likely this method (to READ counter value) should be in the common/ code. Also the client knows the counter values.

It now requires another patch. I wrote number of ticket in comment of patch.

Reply To lachu

It now requires another patch. I wrote number of ticket in comment of patch.

#47827? That has been closed already, but this patch does not apply. You may have based this on older version of #47827 than what got accepted.

2024-02-24 19:57 Updated by: lachu

I do

git switch --detach origin/main git switch -c NAME_OF_NEW_BRANCH git am 0001-OSDN-47829-S-awomir-Lach-slawek-lach.art.pl.patch

It applies.

Reply To cazfi

Reply To lachu

It now requires another patch. I wrote number of ticket in comment of patch.

#47827? That has been closed already, but this patch does not apply. You may have based this on older version of #47827 than what got accepted.

See above. But test patch has one bug. When nobody conquers Portugal city in first turn, game ends and I cannot click next turn. Maybe problem is I set Poe player as reserved?