Fixed some descrepancies in sector information for newly connected clients

• Reporter: akmdm
• Owner: (None)
• Type: Patches
• Status: Closed
• Component: (None)
• MileStone: (None)
• Priority: 5 - Medium
• Severity: 5 - Medium
• Resolution: Accepted
• File: 2

Details Reply

With this patch, the server now only sends information about a sector to newly connected clients if their current values are different from the saved values, not when they're different from the default values (e.g. 0.0 for texture offsets, or 1.0 for texture scale). The fixes the floor alignment issues reported in: https://zandronum.com/tracker/view.php?id=3582

Ticket History (3/6 Histories)

2021-01-04 05:01 Updated by: akmdm

• New Ticket "Fixed some descrepancies in sector information for newly connected clients" created

2021-01-04 05:01 Updated by: akmdm

• File 10240.patch (File ID: 5793) is attached

2021-01-04 06:09 Updated by: torr_samaho

Comment Reply

Thanks for the patch! Looks very good, I just noticed a related problem due to your static_cast<signed> casts: I think instead of casting the results of GetAngle, we should change SavedCeilingAngle and SavedFloorAngle in sector_t to angle_t.

2021-01-11 04:30 Updated by: akmdm

• File 10240_r2.patch (File ID: 5805) is attached

2021-01-11 04:32 Updated by: akmdm

Comment Reply

I made revisions to the previous patch. The data types of SavedCeilingAngle and SavedFloorAngle have been changed to angle_t, so now those static_cast<signed> calls are no longer needed.

2021-01-11 05:36 Updated by: torr_samaho

• Resolution Update from None to Accepted
• Status Update from Open to Closed

Comment Reply

Thanks! I added your updated patch.